Skip to content

Add Bundler integration #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
furunkel wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Bundler integration #7

furunkel wants to merge 3 commits into from

Conversation

@furunkel
Copy link
Contributor

@furunkel furunkel commented Sep 13, 2015

No description provided.

@bnagy
Copy link
Owner

bnagy commented Sep 14, 2015

No bundler, sorry. I hate it.

@bnagy bnagy closed this Sep 14, 2015
@furunkel
Copy link
Contributor Author

furunkel commented Sep 14, 2015

Ugh, ok :).

Can you push the gem to rubygems ?

@disasmwinnie
Copy link

disasmwinnie commented Nov 11, 2016

Could you pls reconsider?
It's extremely painful to deliver tools based on crabstone due the installation process. Since gems are very rare in many distros and therefore bundler is at least some way to distribute.
Having it on rubygems would also be a good step.
Both +1.

@bnagy bnagy reopened this Nov 11, 2016
@bnagy
Copy link
Owner

bnagy commented Nov 11, 2016

OK, I have Uni holidays soon and I'll have a think about this. I don't like Bundler, but if it's the most pragmatic choice then maybe I should just suck it up. Crabstone is lagging anyway, so it needs to be updated and re-tested etc. What it really needs is a new maintainer. sigh

@disasmwinnie
Copy link

disasmwinnie commented Nov 13, 2016

Thanks!
I don't have experience with gems maintaining or bundler specifics and I am at my first capstone project of meaningful size right now. @furunkel do you see yourself as maintainer of crabstone?

@disasmwinnie
Copy link

disasmwinnie commented Nov 13, 2016

Is there any obstacles tied to bundler support for the building process (besides new code)? Like I said I have no experience with that, just curious.

@furunkel
Copy link
Contributor Author

furunkel commented Nov 14, 2016

@hexhouse, not really, no.
Bundler shouldn't cause any issues, though.

@david942j
Copy link

david942j commented Jan 28, 2019

@furunkel just let you know I've pushed crabstone to rubygems.org

david942j added a commit to david942j/crabstone that referenced this pull request Jan 30, 2019
@david942j
Refactor to match Ruby conventions (#1)
0504e59 
* Change file structure, move code in `lib/crabstone.rb` out to split files.
* Add bundler integration as bnagy#7 suggested
* Import rubocop
* Fix memory leak, cherry-pick from https://github.com/kdiv/crabstone/commit/a7bb211a59748e46dde7f4401d83c33ebe19a563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@furunkel @bnagy @disasmwinnie @david942j