Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a gRPC-based Single Sign-On (SSO) integration, replacing the mock IsAdminProvider with a real SSO service client that communicates with an external authentication service. The change enables actual admin verification through a remote gRPC service instead of using in-memory mock data.
Key Changes
- Introduces a new SSO client (
internal/infra/sso) that connects to an external authentication service via gRPC - Removes the mock IsAdminProvider implementation from
internal/infra/mock - Adds SSO configuration support (host and port) to the application config
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
internal/infra/sso/is_admin_provider.go |
New gRPC client for SSO service authentication with IsAdmin functionality |
internal/infra/mock/is_admin_provider.go |
Removed mock implementation that is being replaced by real SSO integration |
internal/config/sso.go |
New configuration struct for SSO connection parameters (host and port) |
internal/config/config.go |
Added SSO field to main Config struct |
cmd/grpc/main.go |
Updated to use real SSO client instead of mock |
tests/suite/suite.go |
Updated test suite to use real SSO client instead of mock |
config/local.yaml |
Added SSO configuration with localhost:44044 as default endpoint |
go.mod |
Updated Go version and added gRPC SSO protos dependency, upgraded gRPC to v1.76.0 |
go.sum |
Updated dependency checksums for new and upgraded packages |
.golangci.yaml |
Modified exhaustruct exclusion pattern (contains an error) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot suggestions Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.