fix quadtree schema bug #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmschmidt
force-pushed
the
03-27-fix_quadtree_schema_bug
branch
from
a43d753 to
74a447d
Compare
bmschmidt
force-pushed
the
03-27-fix_quadtree_schema_bug
branch
from
74a447d to
28365d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a typo in the tests, we weren't actually testing that categorical casting could work for string fields including the case where we started writing to overflow buffers.
It was broken.
This adds the test and provides a fix that chooses an appropriate integer type for the dictionaries based on the cardinality of the categorical field.