handle filesystems #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rguo123
force-pushed
the
03-13-handle_filesystems
branch
4 times, most recently
from
f335a79 to
26d4fe9
Compare
bmschmidt
reviewed
Mar 16, 2025
bmschmidt
reviewed
Mar 16, 2025
rguo123
force-pushed
the
03-13-handle_filesystems
branch
3 times, most recently
from
34bb52b to
b0f082d
Compare
rguo123
force-pushed
the
03-13-handle_filesystems
branch
2 times, most recently
from
c620b44 to
a4077e8
Compare
bmschmidt
force-pushed
the
03-13-handle_filesystems
branch
from
a4077e8 to
db62935
Compare
rguo123
force-pushed
the
03-13-handle_filesystems
branch
2 times, most recently
from
6fc6bfd to
743dc47
Compare
bmschmidt
approved these changes
Mar 20, 2025
| tile.overflow_loc.unlink() | ||
|
|
||
| # TODO: check with Ben that we should delete all the overflows here | ||
| for table in tables: |
Owner
There was a problem hiding this comment.
Does this include the deletion of tile.overflow_loc unlink() too?
Collaborator
Author
There was a problem hiding this comment.
yep! tables includes it
rguo123
force-pushed
the
03-13-handle_filesystems
branch
from
743dc47 to
0cb6dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use pyarrow filesystems for all file I/O to support s3 reads and writes