Merged
Conversation
Also silence warnings
Also, make LCA part of the tree API
Since we already do a DFS, we can save the RPO numbers and enforce that children are sorted by it. This affects several downstream passes.
Instead of changing the IR definition (which would affect many downstream consumers), we can work around this using some existing constructs in the language.
When optimized, the compiler turns this into a lookup table, but we can do even better by just turning it into a shift. However, it requires an unsafe cast.
Also add more tests
bmourad01
force-pushed
the
structured-ir
branch
from
95d1768 to
eb8afba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.