Conversation
9b6bfa2 to
5513f31
Compare
- Unsigned comparisons (need to do this in other places in isel) - the `sub` in jmptbl may be larger than `INT32_MAX`
Just compare them raw. We still only produce a diff when there is an actual failure, because it is of course slower than checking equality on strings.
Yielded some fixes
bfe6fbd to
de3b88a
Compare
We can track the relative byte offsets of each slot that was initialized using the interval tree. Also, do some cleanup of the users of this analysis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.