Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90eb068372
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ] | ||
| }, | ||
| { | ||
| "name": "T-Deck", |
There was a problem hiding this comment.
Avoid duplicate
name entries in t-deck firmware list
Adding another entry with name: "T-Deck" causes the downstream generator to silently overwrite other T-Deck firmwares because 3rd/create_json.py builds new_map as {item["name"].strip(): item} (keyed only by name). In this commit that behavior already changed 3rd/r/t-deck.json from Bruce's T-Deck to Ratdeck, so users consuming the /r feeds get a different firmware than before even though both should coexist; this is a data regression tied to duplicate names in the source list.
Useful? React with 👍 / 👎.
Motivation
github+authorem cada JSON e somente as re-inseria quando encontrava novas releases, causando desaparecimento/aparecimento aleatório de firmwares entre execuções.Description
fids esperados do JSON atual calculados comgenerate_fid, armazenados emexpected_fids.existing_entriesapenas porfidpresente emexpected_fidsalém degithubeauthor, evitando apagar entradas de outros firmwares no mesmo arquivo.fidesteja emexpected_fidse reescrevo-as combinando versões existentes comnew_versions, preservando histórico quando não há novas releases.Testing
python -m py_compile 3rd/update_firmware.pyexecutada com sucesso.Codex Task