Merged
Conversation
…criptor Per the USB MSC spec, class/subclass/protocol must be defined at the interface level, not the device level. Setting them at the device level (TUSB_CLASS_MSC / MSC_SUBCLASS_SCSI / MSC_PROTOCOL_BOT) causes macOS to reject enumeration of the mass storage interface entirely — the device shows in System Information as 'Removable' but never appears in Finder or Disk Utility. Setting bDeviceClass=0x00, bDeviceSubClass=0x00, bDeviceProtocol=0x00 tells the host to look at the interface descriptor for class info, which TUD_MSC_DESCRIPTOR already sets correctly. This matches the behavior of CircuitPython and other correct USB MSC implementations, and fixes macOS compatibility without affecting Windows or Linux.
Owner
|
Thank you brother, it might solve this #184 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the USB MSC spec, class/subclass/protocol must be defined at the interface level, not the device level. Setting them at the device level (
TUSB_CLASS_MSC/MSC_SUBCLASS_SCSI/MSC_PROTOCOL_BOT) causes macOS to reject enumeration of the mass storage interface entirely. The device shows in System Information as 'Removable' but never appears in Finder or Disk Utility.Setting
bDeviceClass=0x00,bDeviceSubClass=0x00,bDeviceProtocol=0x00tells the host to look at the interface descriptor for class info, whichTUD_MSC_DESCRIPTORalready sets correctly. This matches the behavior of CircuitPython and other correct USB MSC implementations, and fixes macOS compatibility without affecting Windows or Linux.