Refactor to be friendlier to Chef 13#46
Merged
tas50 merged 7 commits intobmhatfield:masterfrom Apr 19, 2017
Merged
Conversation
…r to fix races with blocks
Conflicts: providers/domain.rb providers/rule.rb
|
+1 for this one - just ran into an error with chef 13. |
Owner
|
Thanks for the +1 here. I haven't tried Chef 13 yet, and don't have time to scope out that upgrade in the near future. As a substitute, would someone ( @cmoscardi ? ) let me know these changes work for them as-is, and I'll merge this in and release a new version? |
|
Just tried - this fixed my issue, which came from calling the hadoop cookbook source: this line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to be friendlier to Chef 13, which entails modifying the resources to be custom resources rather than LWRPs, making the resources always use inline resources, and removing the code that does resource modification after creation. Tested on Chef 12.6 as well, but probably won't work earlier than 12.5 of course!