Stub distros allowing missing distros to be ignored #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHendricks
force-pushed
the
mikeh/stubs
branch
9 times, most recently
from
19f9ca2 to
2151f4c
Compare
Note: This only works for python 3.8+ as it requires the dep_logic library.
- Moved InvalidRequirementError raise from solvers.py into find_distros. - Fixing a bug that could have caused a invalid requirement to be lost. See changes in hab/solvers.py line 148 and tests/test_resolver.py line 514.
This can be used by Config's to only emit logging messages if they are converted into a FlatConfig.
Stub distros provide a way to prevent raising errors if specific distros are not installed on a workstation. Not all users require workstations capable of running heavy applications so it doesn't make sense to install those applications on the workstation.
Stub_distros is more powerful and flexible. This will automatically convert any existing omittable_distros in configs to config stub_distros. It shows a warning about converting any omittable_distros encountered to stubs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Types of Changes
Proposed Changes
Not all users need access to all of the programs required. For example Producers rarely need to open DCC's like Houdini, but still need access to other tools exposed by hab. This allows you to add per-site
stub_distrosdefinitions that prevent raisingInvalidRequirementErrorif not installed. This doesn't remove the distro from the dependency, instead it adds aStubDistroVersionwith the version0+stub.Allowing stub distros can be done at the site level but can also be overridden per URI config. This improves upon and replaces the omittable_distros system. Omittable distros are converted to URI config stub distros and a warning is logged when using that URI so maintainers know to switch.