Fix gp_log_collector command placeholder - implement actual log collection#9
Merged
bluethumpasaurus merged 1 commit intomasterfrom Sep 18, 2025
Merged
Fix gp_log_collector command placeholder - implement actual log collection#9bluethumpasaurus merged 1 commit intomasterfrom
bluethumpasaurus merged 1 commit intomasterfrom
Conversation
Copilot
AI
changed the title
[WIP] Latest build -
Fix gp_log_collector command placeholder - implement actual log collection
Sep 18, 2025
gp_log_collector command is a placeholder. It does not collect logs as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gp_log_collectorcommand was displaying a placeholder message instead of performing actual log collection functionality. When users ran the command, they would see:$ ./gpmt gp_log_collector I'll be a log collector one dayThis occurred because the command's
Runfunction inlogCollectorCmd.goonly contained placeholder code instead of calling the existing log collection implementation.Changes Made
Connected existing functionality: The
logCollector()function inlogCollector.goalready contained a complete implementation for collecting Greenplum database logs and creating compressed archives. This fix connects that existing functionality to the CLI command.Implemented default value handling: Added proper defaults for command options as noted in the existing FIXME comments:
/tmpif not specifiedAdded proper error handling: The command now exits with status code 1 on errors and displays helpful error messages.
After the fix
The command now attempts actual log collection (the error is expected when no Greenplum installation is present). All command-line options work correctly:
This is a minimal, surgical fix that connects the existing implementation to the CLI without changing the underlying log collection logic or breaking any existing functionality.
Fixes #8.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.