Fix build panic caused by duplicate flag registration in gp_log_collector command#6
Merged
bluethumpasaurus merged 1 commit intomasterfrom Sep 18, 2025
Merged
Conversation
Copilot
AI
changed the title
[WIP] BUILD of Latest Code PANICS
Fix build panic caused by duplicate flag registration in gp_log_collector command
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application was panicking on startup with
panic: gp_log_collector flag redefined: failed-segsdue to duplicate flag and command registration occurring in bothroot.goandlogCollectorCmd.goinit functions.Root Cause
The issue occurred because:
root.goinit() was callingflagsLogCollector()androotCmd.AddCommand(logCollectorCmd)logCollectorCmd.goinit() was also callingflagsLogCollector()androotCmd.AddCommand(logCollectorCmd)--failed-segs) to be registered twice, triggering Cobra's pflag library to panicSolution
Removed the duplicate registration calls from
root.goand followed Go's init() function best practices where each command manages its own registration completely within its own init() function. This maintains clean separation of concerns while eliminating the duplicate registration issue.Testing
The fix has been validated with:
./gpmt-linux-amd64 --helpand./gpmt-linux-amd64(both previously panicked)version,gp_log_collector--failed-segsflag now functions properlyFixes #5.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.