-
Notifications
You must be signed in to change notification settings - Fork 272
improve pdsadmin invite based commands #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
improve pdsadmin invite based commands #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates invite code management into a new unified invite.sh script with enhanced functionality, replacing the basic create-invite-code.sh command. The new script provides both creation and listing capabilities with filtering options.
- Adds
pdsadmin invitecommand withlistandcreatesubcommands - Replaces deprecated
create-invite-codecommand with improvedinvite create - Adds filtering options for listing invite codes (used, disabled, free)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pdsadmin/invite.sh | New comprehensive invite code management script with list and create subcommands, including filtering capabilities |
| pdsadmin/help.sh | Updated help documentation to include new invite command and mark create-invite-code as removed |
| pdsadmin/create-invite-code.sh | Removed old single-purpose invite code creation script |
| README.md | Updated documentation to reference new pdsadmin invite create command instead of deprecated create-invite-code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This looks OK! However, these shell scripts aren't as actively maintained as https://github.com/bluesky-social/goat will be moving forward, and I'd like to at least keep them backwards compatible if we are considering any syntax changes. I can't promise we can merge this, but we're definitely likelier to merge it if it retains the old syntax as a backup. |
|
Will update to add backwards compatibility! |
|
@axfelix the bsky offical hosting guide should prob be updated to have people use goat if thats the better maintained thing going forward |
|
Definitely, and we're in the middle of a big docs refresh you can see at bluesky-social/atproto-website#483 which should help with this! Which guide did you follow, so I know if there's anything else unclear out there? |
|
https://github.com/bluesky-social/pds#creating-an-account-using-an-invite-code this was what lead me to using the old command! |
|
updates look super cool! very exited! |
|
@axfelix let me know if I can do anything to help in anyway! I love atproto! |
|
This is good for re-review now. |
I was trying to do this and it was frustrating me, so i've made a pr to improve things.