Limit watchtower scope and integrate better with systemd #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes bluesky-social#49 By not using oneshot service type and not detaching the docker compose command you can use normal systemd tools (e.g. journalctl) for logs. Docker commands still work too. Signed-off-by: Justin Garrison <justinleegarrison@gmail.com>
Contributor
|
Inclined to merge this, @bnewbold ? |
Contributor
|
I think improvements here would be good, and these look like probably the right direction. I am not super familiar with watchtower, and know process monitoring stuff can be subtle. I'd want somebody to do an independent pass over this to check the watchtower docs, and to try setting up a PDS this way and confirm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49
By not using oneshot service type and not detaching the docker compose command you can use normal systemd tools (e.g. journalctl) for logs. Docker commands still work too.