relay: hint PG for perf on listRepos #1237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in the comment, adding an actual foreign key relationship would probably help with this. But doing it as a query tweak is a simpler change to deploy (no schema change).
Contributor
|
Makes sense to me, this is what the query planner should do, but doesn't for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in the comment, adding an actual foreign key relationship would probably help with this. But doing it as a query tweak is a simpler change to deploy (no schema change).
I have tested this in prod and it helped a bunch with perf. I have not tested even locally with an actual call to listRepos, should do that before merging+deploying.
closes: #1236