Skip to content

Conversation

@ArturoManzoli
Copy link
Contributor

@ArturoManzoli ArturoManzoli commented Nov 18, 2025

  • Add Mission control panel widget and mini-widget;
  • Add active waypoint skip/select by context menu on map widget;
  • Add skip to next and previous waypoints via control panel;
  • Add mission play, pause and stop via control panel;
Screenshare.-.2026-01-27.12_14_26.PM.mp4

Close #2032
Close #2119
Partially solves issue #2141

@ES-Alexander
Copy link
Contributor

From a quick look through the code (haven't tested yet), it generally looks like it makes sense :-)

I'm curious whether there's any special functionality in the main widget version of the control panel though - if not it should maybe only be available as a mini widget (which should already be able to go into a collapsible container if someone wants it in one)?

In terms of state tracking, it could be nice to differentiate the "visited" waypoints (not just the current target). I'm not sure whether we'd consider it sufficient to just display everything prior to the target as visited, or if we think it's worth actually keeping track of which ones have been reported as visited (and potentially even count how many times)...

I think it could be nice to display the "current target" waypoint as a target icon - possibly just adding an extra ring around it? As I understand it targets are a well-understood symbol, which should make it more immediately obvious what it means for that waypoint to be highlighted/different.

@ArturoManzoli
Copy link
Contributor Author

I'm curious whether there's any special functionality in the main widget version of the control panel though - if not it should maybe only be available as a mini widget (which should already be able to go into a collapsible container if someone wants it in one)?

I agree that having both the mini and regular widgets for certain features can feel redundant, but for Mission Planning there are two main reasons to keep both:

  • Some less-experienced users may find it difficult or unintuitive to build a widget using the collapsible container combined with the mini-widget. Since Mission Planning is a core component of Cockpit, providing it in both mini and regular widget formats makes sense.
  • The regular Mission Planning widget is still in an early stage. As discussed earlier, we plan to add many more mission-control features, switches, menus, and monitoring elements that wouldn’t have enough space in a mini-widget.

In terms of state tracking, it could be nice to differentiate the "visited" waypoints (not just the current target). I'm not sure whether we'd consider it sufficient to just display everything prior to the target as visited, or if we think it's worth actually keeping track of which ones have been reported as visited (and potentially even count how many times)...

Agreed; Issue #2246 has been created to implement that.

I think it could be nice to display the "current target" waypoint as a target icon - possibly just adding an extra ring around it? As I understand it targets are a well-understood symbol, which should make it more immediately obvious what it means for that waypoint to be highlighted/different.

“Targets” does refer to a location to go, but it also carries weapon and shooting related meanings, which I think doesn’t really fit the friendly tone we want our products to have.

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Jan 13, 2026

@ArturoManzoli can you rebase this PR? I want to resume its review.

@ArturoManzoli
Copy link
Contributor Author

@ArturoManzoli can you rebase this PR? I want to resume its review.

@rafaellehmkuhl Done!

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition.
Three things to be worked on:

  1. The current WP indication is overflowing in the mini-widget.
  2. The current WP indication is not present in the regular widget.
  3. Since we are removing the controls from the map widget, I believe we should add a migration that adds the regular mission control widget by default in the views that have map widgets, probably on the bottom-right corner. It should be done only once, so needs a migration flag (something like hasAddedMissionControlWidgetAfterMigration) in the migrations.ts file.
Image

Comment on lines 350 to 356
/**
*
*/
downloadMissionFromVehicle: () => Promise<void>
/**
*
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs.

@ArturoManzoli ArturoManzoli force-pushed the 2032-set-wp-as-active branch 2 times, most recently from e9307a4 to c700775 Compare January 23, 2026 17:37
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…n functions

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…sion functions

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…widget and mini-widget

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
@ArturoManzoli
Copy link
Contributor Author

  1. The current WP indication is overflowing in the mini-widget.

Couldn't reproduce here, but added some constrains so it won't happen again anyway. Could have been an issue specific to your OS.

  1. The current WP indication is not present in the regular widget.

Added that now!

  1. Since we are removing the controls from the map widget, I believe we should add a migration that adds the regular mission control widget by default in the views that have map widgets, probably on the bottom-right corner. It should be done only once, so needs a migration flag (something like hasAddedMissionControlWidgetAfterMigration) in the migrations.ts file.

Tried doing the migration inside the migrations.ts file, but it after speaking in private with @rafaellehmkuhl we decided that the best solution was to do the migrations inside the widgetManager store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants