Skip to content

Conversation

@rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Nov 12, 2025

image

Fix #2202

@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-vehicle-address-base-url-on-iframe branch 2 times, most recently from 47d9bc9 to bbfcfa7 Compare November 12, 2025 14:46
Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mainly works, but somehow the old address is sticky on the Text input Field:

Screenshare.-.2025-11-12.1_53_53.PM.mp4

@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-vehicle-address-base-url-on-iframe branch from bbfcfa7 to 01d7e27 Compare November 13, 2025 15:08
@rafaellehmkuhl
Copy link
Member Author

From our external discussion around that part I modified the behavior of this field to clear the URL if the user clicks the switch without having used that case (baseURL enabled vs not enabled) before, or reusing the last inputed URL if the user has already typed something there during the current session. That way we prevent the user to have to re-input the entire URL if they click the button by mistake or just to take a look on what it does.

Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine, and in an intuitive way now!

@rafaellehmkuhl rafaellehmkuhl merged commit 81c77d5 into bluerobotics:master Nov 13, 2025
12 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the allow-vehicle-address-base-url-on-iframe branch November 13, 2025 17:10
@joaoantoniocardoso
Copy link
Member

How can I enable it from the cockpit external widget API?

@rafaellehmkuhl
Copy link
Member Author

How can I enable it from the cockpit external widget API?

Will be added on a following PR. I didn't want to implement it in this one yet so there's no much rebase to be done on the #1962.

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-needed Change needs to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iFrames should be allowed to use an automatically updated vehicle address in the URL

4 participants