Allow usage of string variables in the Very Generic Indicator #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES-Alexander
reviewed
Sep 9, 2025
Comment on lines
+98
to
+108
| <div class="flex items-center justify-start w-full mt-3"> | ||
| <input | ||
| id="useStringVariable" | ||
| v-model="miniWidget.options.useStringVariable" | ||
| type="checkbox" | ||
| class="mr-2 w-4 h-4 rounded bg-[#FFFFFF12] border-gray-300 focus:ring-blue-500" | ||
| /> | ||
| <label for="useStringVariable" class="text-sm text-slate-100/75"> | ||
| Use string variable (don't parse as number) | ||
| </label> | ||
| </div> |
Contributor
There was a problem hiding this comment.
If data-lake variables have known types, could we infer this automatically from the selected variable, instead of requiring the user to configure it?
Member
Author
There was a problem hiding this comment.
We could, but that is not well enforced yet. I think it's better for now to just allow this to be explicitly done before we take a deeper look at the enforcing.
Member
Author
ArturoManzoli
approved these changes
Sep 12, 2025
Contributor
ArturoManzoli
left a comment
ArturoManzoli
left a comment
There was a problem hiding this comment.
Nice! This will be very useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till now only variables of
numbertype were supported, as the value was always trying to be parsed as one.This will come in handy specially after we merge #1944, as the users will be able to use the VGI to show a custom status, for example.