-
Notifications
You must be signed in to change notification settings - Fork 121
Add small fixes to bootstrap #3774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrickelectric
wants to merge
6
commits into
bluerobotics:master
Choose a base branch
from
patrickelectric:fix-bootstrap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add small fixes to bootstrap #3774
patrickelectric
wants to merge
6
commits into
bluerobotics:master
from
patrickelectric:fix-bootstrap
+43
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideMinor bootstrap cleanups: improve type hints, logging, and comments, and adjust tooling configuration for import ordering and project structure. Updated class diagram for Bootstrapper in bootstrap moduleclassDiagram
class Bootstrapper {
<<class>>
+bool version_chooser_is_online
+float core_last_response_time
+DockerClient client
+APIClient low_level_api
+__init__(DockerClient client, Optional_APIClient low_level_api)
+run()
}
class DockerClient {
}
class APIClient {
}
class Optional_APIClient {
}
DockerClient <.. Bootstrapper : uses
APIClient <.. Bootstrapper : optional uses
Optional_APIClient <|-- APIClient
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- In
overwrite_config_file_with_defaults, the warning message says the backup is being created whenFileNotFoundErroroccurs, but the code skips backup creation and only copies the default config; consider adjusting the message or behavior so the log matches what actually happens.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `overwrite_config_file_with_defaults`, the warning message says the backup is being created when `FileNotFoundError` occurs, but the code skips backup creation and only copies the default config; consider adjusting the message or behavior so the log matches what actually happens.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
4268f67 to
2e48960
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
2e48960 to
d1bca54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Tighten bootstrap configuration handling and developer tooling settings.
Enhancements: