Skip to content

Conversation

@patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Feb 8, 2026

Summary by Sourcery

Tighten bootstrap configuration handling and developer tooling settings.

Enhancements:

  • Add optional typing for the low-level Docker API client in the bootstrapper constructor.
  • Log a warning when the Docker config backup file is missing instead of silently ignoring it.
  • Correct a bootstrap comment typo and align import and isort configuration for the bootstrap package as a first-party module.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 8, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Minor bootstrap cleanups: improve type hints, logging, and comments, and adjust tooling configuration for import ordering and project structure.

Updated class diagram for Bootstrapper in bootstrap module

classDiagram
    class Bootstrapper {
        <<class>>
        +bool version_chooser_is_online
        +float core_last_response_time
        +DockerClient client
        +APIClient low_level_api
        +__init__(DockerClient client, Optional_APIClient low_level_api)
        +run()
    }

    class DockerClient {
    }

    class APIClient {
    }

    class Optional_APIClient {
    }

    DockerClient <.. Bootstrapper : uses
    APIClient <.. Bootstrapper : optional uses
    Optional_APIClient <|-- APIClient
Loading

File-Level Changes

Change Details Files
Make Docker low-level API parameter explicitly optional in Bootstrapper constructor.
  • Change constructor type annotation from docker.APIClient to Optional[docker.APIClient].
  • Keep runtime behavior the same by preserving default None value.
bootstrap/bootstrap/bootstrap.py
Improve logging and comments around Docker config backup and core restart logic.
  • Replace silent FileNotFoundError handling with a warning log when the Docker config file backup is missing.
  • Fix typo in comment describing version chooser failure and core restart behavior.
bootstrap/bootstrap/bootstrap.py
Align tooling and imports with project structure.
  • Add bootstrap to isort known_first_party configuration to enforce correct import grouping.
  • Keep Bootstrapper import in main module (likely reformatting/no-op change).
core/pyproject.toml
bootstrap/main.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In overwrite_config_file_with_defaults, the warning message says the backup is being created when FileNotFoundError occurs, but the code skips backup creation and only copies the default config; consider adjusting the message or behavior so the log matches what actually happens.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `overwrite_config_file_with_defaults`, the warning message says the backup is being created when `FileNotFoundError` occurs, but the code skips backup creation and only copies the default config; consider adjusting the message or behavior so the log matches what actually happens.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant