Introduce v6:DhcpOption::code()
#92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing `v6::DhcpOption::code()` so crate user could store it into HashMap. The v4 does not have, but `v4::DhcpOptions::iter()` already contain option code for it. Signed-off-by: Gris Ge <fge@redhat.com>
Collaborator
Pull Request Test Coverage Report for Build 18005088611Details
💛 - Coveralls |
Contributor
Author
|
Closing as I decided to implement DHCP parsing/emitting by myself as this crate is depending too many crates. |
Collaborator
|
Fair enough. Now that you mention it, we could probably remove a few. The biggest one is hickory-proto. For that we'd need an impl that parses dns names to replace it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
v6::DhcpOption::code()so crate user could store it intoHashMap.
The v4 does not have, but
v4::DhcpOptions::iter()already containoption code for it.