Skip to content

Conversation

@MoonPadUSer
Copy link
Contributor

@MoonPadUSer MoonPadUSer commented Jun 27, 2020

See issue #90
This new menu is supposed to make it easier for newbies and oldies to modify weapons to their desire,
the file I started with was from @IceflowRE but is largely modified by me
This is a first prototype and I'd like to merge it so I can get feedback from the users.

You can show the menu by pressing F7

@MoonPadUSer MoonPadUSer added enhancement New feature or request user interface labels Jun 27, 2020
@MoonPadUSer MoonPadUSer self-assigned this Jun 27, 2020
@MoonPadUSer MoonPadUSer linked an issue Jun 27, 2020 that may be closed by this pull request
@MoonPadUSer MoonPadUSer changed the title Rework variables menu Add separate weapon variables menu Jun 27, 2020
@MoonPadUSer MoonPadUSer requested a review from shacknetisp July 5, 2020 09:51
@shacknetisp
Copy link
Contributor

Some warnings to fix:

/home/user/src/blue-nebula/src/game/client.cpp: In function ‘void client::writegamevars(const char*, bool, bool, const char*)’:
/home/user/src/blue-nebula/src/game/client.cpp:260:45: warning: comparison with string literal results in unspecified behavior [-Waddress]
         bool export_weapon = weapon_name != "";
                                             ^~
/home/user/src/blue-nebula/src/game/client.cpp:267:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (size_t i = 0; i < ids.size(); i++)
                            ~~^~~~~~~~~~~~

@MoonPadUSer
Copy link
Contributor Author

MoonPadUSer commented Jul 17, 2020

on my way...
Edit: Fixed.

@TheAssassin
Copy link
Member

TheAssassin commented Jul 17, 2020

In the sense of #100, we should consider adding -Werror -Waddress (and maybe -Wsign-compare) to prevent such issues in the future in a separate PR.

@TheAssassin TheAssassin added this to the 1.7.0 milestone Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Separate Weapon Variable Menu

4 participants