Add Colorscheme Options #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidanix
requested changes
Dec 10, 2021
Member
voidanix
left a comment
voidanix
left a comment
There was a problem hiding this comment.
- This does not work apparently, seems to fail with a
unknown command: setcolorsin the console when pushing the 2 new buttons. - The
activebutton and thepick a colour for the variable /ui_color_activeseem clunky and confusing. - Got some whitespace at https://github.com/blue-nebula/base/pull/214/files#diff-59c8b041b4a3f9cd0dfa9d5311b1a7994a540dff82848bb05970571c99ee7f7eR306
- The
colorscheme_"containers" (?) should probably have a docstring e.g. why is the default one resetting vars?
Barely knowing any cubescript at all, this is only a general review but hopefully you get the idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to choose between 2 colorschemes, one of them being the default red eclipse colorscheme and the other being an experimental blue nebula colorscheme I created, this is mainly to provide an easy way for users to try out colorschemes and give feedback
