Remove loop* and loopv* macros from menus.cpp

[MoonPadUSer]

Basically just doing a little bit of refactoring by getting rid of all loop macros in src/engine/menus.cpp

[robalni]

You're using a different code style, '{' on same line and space after if and for.

[MoonPadUSer]

@robalni Indeed, I do. Because:

for (int i = 0; i < 2; i++) {
    printf("This is fine\n");
}

saves space and is just as easy to read as

for (int i = 0; i < 2; i++)
{
    printf("This is great too!\n");
}

I only like to do that when there's only one line inside the curly brackets (I hope I didn't violate that rule in here)

[robalni]

I prefer to have everything the same, otherwise it will look like a mess after a while.

[MoonPadUSer]

Hum, ok, can't hurt. :) will change it

[MoonPadUSer]

alright, now it should be good.

[TheAssassin]

I would suggest not to just stubbornly replace all occurrences of the macro, but just go for the more modern iterator-based loops where applicable. How about

Suggested change

	for (int i = 0; i < needsapply.length(); i++)
	for (const auto& i : needsapply)

If you can not use this approach, please don't use the deprecated length() but the STL-compatible size().

Applies to pretty much all loops you modified.

[MoonPadUSer]

Yeah, I'll do that