-
Notifications
You must be signed in to change notification settings - Fork 8
Add Force Vote (Veto) Button back to map selector #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| show_force_button = 0 | ||
| if (&& (getclientpriv $getclientnum $vetolock) (=s (getmastermode 1) "veto")) [ | ||
| show_force_button = 1 | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are showing the force button, then you probably shouldn't have the normal vote button which also forces. Perhaps have a button to force a new vote on the selection screen and a button to force your current vote on the votes screen, or a similar arrangement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but... the normal Vote button doesn't force?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does, if mastermode is set to veto and you have veto privs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh... well that smth we could change, Imo you should still be able to normally vote, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, why should you? veto mode is something rarely used anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the question is: why should we NOT do it
The veto button was forgotten in our new map selector menu, thus I added it back in:
No worries, the screenshot was just taken at a bad moment, the Force button is actually blinking like it did before