Skip to content

Conversation

@robalni
Copy link
Contributor

@robalni robalni commented Jul 25, 2020

The movie command was removed by mistake in 44b24a1 and this pull request brings it back.

Robert Alm Nilsson added 3 commits July 25, 2020 22:32
This reverts commit 44b24a1.

The `movie` command was removed by mistake.  This commit brings it back.
This reverts commit 194c212.

The `movie` command was removed by mistake.  This commit brings it back.
@ghost
Copy link

ghost commented Jul 25, 2020

Could you please add some documentation around to explain what it does and how it does it, so that the mistake won't happen anew?

@TheAssassin
Copy link
Member

was removed by mistake

It wasn't a mistake, really. IIRC we figured hardly anyone uses it. To me, at least, it was clear it was used to record, not play movies. See #23.

I'm very open to reverting those changes given there's actual users. I agree to @bmorel that it should probably be documented a bit better in order to avoid misunderstandings of any kind in the future.

@TheAssassin
Copy link
Member

I think what @bmorel meant was to add some comments in the code to mark which code belongs to the recorder to prevent future readers from thinking "ah well we don't need that any more" and removing the code...

@MoonPadUSer
Copy link
Contributor

I think what @bmorel meant was to add some comments in the code to mark which code belongs to the recorder to prevent future readers from thinking "ah well we don't need that any more" and removing the code...
qwe_download

@TheAssassin TheAssassin added this to the 1.7.0 milestone Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants