Skip to content

Conversation

@MoonPadUSer
Copy link
Contributor

@MoonPadUSer MoonPadUSer commented Jul 14, 2020

Demonstration:
Invidious
Youtube

It shows 5 completions at once, allows switching between completions using UP and DOWN, you can complete the selected completion like usual with TAB

@MoonPadUSer MoonPadUSer added the enhancement New feature or request label Jul 14, 2020
@MoonPadUSer MoonPadUSer self-assigned this Jul 14, 2020
@MoonPadUSer MoonPadUSer requested a review from TheAssassin July 14, 2020 12:18
@MoonPadUSer MoonPadUSer marked this pull request as draft July 14, 2020 13:18
@MoonPadUSer MoonPadUSer marked this pull request as ready for review July 15, 2020 03:27
@robalni
Copy link
Contributor

robalni commented Jul 25, 2020

I tested this and here are a few problems that I found.

Can't reach more than 5 suggestions.

Example: I don't remember the command name "smgfragweap1" so I type "/smgfrag". With the old completion I could tab until I reached the command I wanted. With this one I can't reach it at all because I can only choose from the 5 visible suggestions.

Arguments are deleted.

Example: I type "/dm dark" and then press tab because I want to play on Darkness. With the old completion this works. With this one the "dark" is deleted and I only see "/dm ".

Previous completions stay in memory and used next time.

Example: I type "/smgfragweap1" and press tab and then escape. Now I open the chat again and type anything at all and then press tab again. Now everything I typed is deleted and replaced with "/smgfragweap1 ".

@MoonPadUSer
Copy link
Contributor Author

@robalni You are completely right, I have noticed those problems too, but sadly I haven't found the time to fix them yet :(
But to "solve" the only 5 suggestions problem I'd like to improve the completion itself because currently the order depends on the idents hashnameset. Thank you :)

@TheAssassin TheAssassin added this to the 1.7.0 milestone Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants