Skip to content

fix(default-flatpaks): remove check for fedora-third-party opt-out#516

Open
ibaidev wants to merge 2 commits intoblue-build:mainfrom
ibaidev:main
Open

fix(default-flatpaks): remove check for fedora-third-party opt-out#516
ibaidev wants to merge 2 commits intoblue-build:mainfrom
ibaidev:main

Conversation

@ibaidev
Copy link
Contributor

@ibaidev ibaidev commented Dec 10, 2025

This change simplifies Fedora third-party repository opt-out in system-flatpak-setup by removing the call to /usr/lib/fedora-third-party/fedora-third-party-opt-out and using /usr/bin/fedora-third-party disable when available.

The opt-out helper is single-purpose: it flips the third-party status from unset to disabled and exists to allow a different pkexec configuration so an admin can opt out without authenticating on first run. This seems the best option if we bootc switch from a fresh install, but if the third-party status has already been set, any call to this helper prints a message directing callers to /usr/bin/fedora-third-party disable and returns a non-zero exit code, which causes our setup flow to abort before the intended disable step can run.

There may be a more sophisticated way to solve this, but relying directly on /usr/bin/fedora-third-party disable removes the redundant helper invocation, avoids the premature failure path, and ensures the disable action executes consistently on both first and subsequent runs.

Copy link
Member

@xynydev xynydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning sounds solid here. Hope this is the case, as I'm approving the change :p

Sorry it took so long

Copilot AI review requested due to automatic review settings January 26, 2026 17:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@xynydev
Copy link
Member

xynydev commented Jan 26, 2026

Why the f-- did copilot try to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants