🛡️ Sentinel: Fix shell variable quoting issues in entrypoint #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel Security Fix
Vulnerability: Input handling flaw in
copyables/entrypoint.shSeverity: MEDIUM
What was found:
$usernameand$passwordwere used unquoted inaddusercalls. This causes passwords with spaces (e.g., "secret pass") to be split into multiple arguments, resulting in only the first part ("secret") being set as the password.$CERTand$KEYwere used unquoted inechocommands. If these variables contained*or other glob characters, the shell would expand them to file listings, potentially leaking file existence or causing unexpected behavior.The Fix:
$username,$password,$CERT, and$KEYvariables to ensure they are treated as literal strings.Verification:
bash -n.PR created automatically by Jules for task 17784029209023714010 started by @bluPhy