🛡️ Sentinel: Fix password handling and command parsing vulnerabilities

[google-labs-jules]

🛡️ Sentinel Security Fix

Vulnerability:

1. Improper Input Handling: Passwords containing spaces were incorrectly truncated due to unquoted variable expansion in entrypoint.sh. Passwords containing backslashes were corrupted by read without -r.
2. Globbing Risk: Unquoted variables allowed potential globbing (wildcard expansion) against the filesystem when processing commands.
3. Command Injection / Logic Error: The loop for VPNCMD_SERVER and VPNCMD_HUB incorrectly processed semicolon-separated commands, executing only the first command in the list.

Fix:

• Added -r to all read commands to preserve backslashes.
• Quoted $username and $password variables to prevent word splitting and globbing.
• Implemented correct array iteration for VPNCMD_* variables to execute all commands.
• Used set -f (noglob) around dynamic command execution to safely allow argument splitting without filesystem globbing.

Verification:

• Added tests/verify_password_fix.sh which reproduces the issues and verifies the fixes.
• Verified script syntax with bash -n.

Journal:

• Added entry to .jules/sentinel.md regarding shell script input handling risks.

---

PR created automatically by Jules for task 14100508329879748494 started by @bluPhy

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}