🛡️ Sentinel: Fix password truncation for passwords with spaces #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel: [CRITICAL/HIGH] Fix password truncation
Severity: HIGH
Vulnerability: Unquoted variables in
entrypoint.shcaused passwords containing spaces to be truncated (e.g., "my secret" became "my"). This could lead to weaker passwords than intended or correct passwords being rejected if they contained spaces.Impact: Users setting passwords via the
USERSenvironment variable would silently have their passwords truncated if they contained spaces.Fix: Quoted the
$usernameand$passwordvariables in theadduserfunction calls and usedread -rfor safer string reading.Verification: Added
tests/verify_password_fix.shwhich mocks thevpncmdenvironment and verifies that passwords with spaces are passed correctly to the underlying command.PR created automatically by Jules for task 15902443492047366560 started by @bluPhy