🛡️ Sentinel: Fix insecure password handling and command execution logic

[google-labs-jules]

🛡️ Sentinel: [MEDIUM] Fix shell variable expansion and logic errors in entrypoint

Vulnerability:

1. Unquoted variable expansion in adduser $username $password caused passwords containing spaces to be truncated (e.g., "secure pass" became "secure").
2. Logic error in VPNCMD_SERVER and VPNCMD_HUB loops caused only the first command in a semicolon-separated list to be executed, potentially skipping security configurations.

Fix:

• Quoted all variables in adduser call: adduser "$username" "$password".
• Refactored VPNCMD_* loops to correctly iterate over the array of commands.
• Quoted $CONFIG variable usage.

Verification:

• Verified syntax with bash -n.
• Created and ran a reproduction script (temporary) that confirmed the fix handles passwords with spaces correctly.
• Logic review confirms the loop fix ensures all configuration commands are executed.

---

PR created automatically by Jules for task 2163064463057733200 started by @bluPhy

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}