🛡️ Sentinel: Fix password truncation for passwords with spaces #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel Security Fix: Prevent Password Truncation
Vulnerability:
The
entrypoint.shscript used unquoted variable expansion when adding users:adduser $username $password. If a password contained spaces (e.g., "secure phrase"), the shell would split it into multiple arguments. Theadduserfunction, which callsvpncmd_hub, would then use only the first word as the password. This meant users believing they had a strong passphrase actually had a truncated one.Fix:
Quoted the variables:
adduser "$username" "$password". This ensures the password is treated as a single argument, preserving spaces and special characters.Verification:
Added
tests/verify_password_fix.shwhich mocks the internal functions to demonstrate the failure with unquoted variables and success with quoted ones.Verified that the fix correctly passes the full password string.
PR created automatically by Jules for task 2742173403342152479 started by @bluPhy