Skip to content

🛡️ Sentinel: Allow configurable Cipher Suite #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

🛡️ Sentinel: Allow configurable Cipher Suite #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2025-01-09 - Hardcoded Cipher Suite
**Vulnerability:** The `entrypoint.sh` script hardcoded `DHE-RSA-AES256-SHA` as the only allowed cipher suite using `ServerCipherSet`.
**Learning:** This restriction prevents users from utilizing modern, stronger ciphers like `AES256-GCM-SHA384` (TLS 1.2) unless they modify the entrypoint script. Hardcoding security configurations limits adaptability and improvements.
**Prevention:** Always expose security parameters (like cipher suites, protocols, key lengths) as configuration variables (env vars) with secure defaults.
3 changes: 2 additions & 1 deletion copyables/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,10 @@ if [ ! -f $CONFIG ] || [ ! -s $CONFIG ]; then

# while-loop to wait until server comes up
# switch cipher
: ${CIPHER_SUITES:='DHE-RSA-AES256-SHA'}
while :; do
set +e
vpncmd_server ServerCipherSet DHE-RSA-AES256-SHA 2>&1 >/dev/null
vpncmd_server ServerCipherSet "${CIPHER_SUITES}" 2>&1 >/dev/null
[[ $? -eq 0 ]] && break
set -e
sleep 1
Expand Down