-
Notifications
You must be signed in to change notification settings - Fork 0
Rename dp CLI to dl (DevLaunch) #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rename the devpod CLI wrapper from `dp` to `dl` (DevLaunch) for a cleaner command name. Updates all references including module names, cache directories, completions, tests, and adds legacy cleanup for machines with existing dp installations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Reviewer's GuideRenames the DevPod wrapper CLI from Sequence diagram for dl completion installation and dp cleanupsequenceDiagram
actor User
participant dl as dl_CLI
participant completion as completion_module
participant rc as ShellRCFile
participant bash as BashCompletionScript
User->>dl: run dl --install
dl->>completion: install_all_completions(rc_path)
completion->>rc: read rc file (if exists)
rc-->>completion: existing content (may include dp completion block)
completion->>completion: scan for RC_BLOCK_START patterns
completion->>completion: map "# dp completion" to "# end dp completion"
completion->>completion: remove existing dp completion block if present
completion->>bash: load_completion_script(dl)
bash-->>completion: dl.bash script (uses ~/.cache/dl/completions.json)
completion->>rc: write combined completion script
rc-->>completion: updated rc content (only dl completion block)
completion-->>dl: return exit code 0
dl-->>User: installation complete, dp completion cleaned up
Flow diagram for updated dl completion installation and cache usageflowchart TD
A[Start dl --install] --> B[Call install_all_completions]
B --> C[Determine rc_path]
C --> D[Open rc file or create if missing]
D --> E[Read existing content]
E --> F[Remove known completion blocks
including dp completion block
using RC_BLOCK_START to RC_BLOCK_END map]
F --> G[Load rockerc bash completion script]
G --> H[Load renv completion script]
H --> I[Load aid completion script]
I --> J[Load dl completion script
from dl.bash]
J --> K[Combine scripts into single completion block]
K --> L[Write combined script to rc file]
L --> M[User opens new shell]
M --> N[bash sources rc file]
N --> O[dl completion function _dl_completion defined]
O --> P[User types dl <TAB>]
P --> Q[_dl_completion reads cache file
at ~/.cache/dl/completions.json]
Q --> R[Suggest workspace completions]
R --> S[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since the cache directory has been renamed from
~/.cache/dpto~/.cache/dl, consider adding a small migration/cleanup step that copies or removes any existing~/.cache/dpdata so users don’t lose useful cached completions or accumulate stale files. - You might want to keep a temporary
dpconsole_script entry point (invokingrockerc.dl:mainwith a deprecation warning) to ease the transition for users with existingdpaliases, scripts, or muscle memory.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the cache directory has been renamed from `~/.cache/dp` to `~/.cache/dl`, consider adding a small migration/cleanup step that copies or removes any existing `~/.cache/dp` data so users don’t lose useful cached completions or accumulate stale files.
- You might want to keep a temporary `dp` console_script entry point (invoking `rockerc.dl:main` with a deprecation warning) to ease the transition for users with existing `dp` aliases, scripts, or muscle memory.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 63.04% 63.04%
=======================================
Files 9 9
Lines 1840 1840
=======================================
Hits 1160 1160
Misses 680 680
🚀 New features to boost your workflow:
|
Summary
dpCLI todl(DevLaunch) across all code, tests, and completions~/.cache/dp/to~/.cache/dl/dpcompletions to ensure clean migration on existing installationsTest plan
dl --installremoves olddpcompletion blocks from.bashrcdlcommand works afterpixi install🤖 Generated with Claude Code
Summary by Sourcery
Rename the DevPod CLI wrapper to the new DevLaunch "dl" command and update associated configuration, cache paths, and completions accordingly.
Enhancements:
Build: