Open
Conversation
epicallan
force-pushed
the
add/lambda-client
branch
6 times, most recently
from
2d4cb14 to
c3a336b
Compare
epicallan
commented
Jan 19, 2021
src/AWS/Lambda/Runtime.hs
Outdated
|
|
||
| runtime | ||
| :: ToJSON result | ||
| => (Either ClientError LambdaResponse -> IO (Either Text result)) |
Contributor
Author
There was a problem hiding this comment.
I remember you mentioned that you would prefer we integrated with RIO; but I failed to find a compelling reason to use it within the runtime function where the env would potentially be the lambdaContext. However, I am happy to reconsider.
Furthermore, adding lambdaContext as an env value requires what I currently consider internal library implementation detail and its generation is an effect that can lead to lambda client errors and there is no way of retrieving it without obtaining lambda-event data since it has both static and dynamic data retrieved from lambda-even HTTP headers.
epicallan
force-pushed
the
add/lambda-client
branch
5 times, most recently
from
a57b055 to
cfcd02e
Compare
epicallan
force-pushed
the
add/lambda-client
branch
from
cfcd02e to
c7d55f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.