fix: Refactor trailer fields statistics calculations to allow individual data record update#16
Open
steven-liou wants to merge 19 commits intomasterfrom
Open
fix: Refactor trailer fields statistics calculations to allow individual data record update#16steven-liou wants to merge 19 commits intomasterfrom
steven-liou wants to merge 19 commits intomasterfrom
Conversation
…rect position in metro2
…eckFix Correction indicator check fix
…ifact-actions chore(deps): update actions/download-artifact action to v5
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.10 to 1.16.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.10...v1.16.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.5 to 1.18.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.16.5...v1.18.3) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…and removing all other calcs, and setting first name on j2 as nullable because there are instance where business personally liable where first name may not be set
…ble-legnth-fix variable length and J2 fixes
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- Replace inefficient string concatenation to reduce CPU usage, memory allocations, and garbage collections - This change significantly improves performance for large files with many records
…ler records Moving trailer generation statistics methods from fileInstance to TrailerRecords and PackedTrailerRecords to allow direct write of individual data record to disk, and update the trailer record manually. Keeping TrailerInformation struct for backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor moov library to be able to update trailer record statistics with individual data record.
fileInstancehold all processed data records, and then generate header, data record, and trailer segments result in high memory usage when there are millions of data records.fileInstance, reduces memory usageAC:
fileInstance.generatorTrailer()andfileInstance.generatorPackedTrailer()that cover all trailer segment fields statistics (all account statuses and total segment fields calculations)fileInstance.generatorTrailer()andfileInstance.generatorPackedTrailer()and their related statistics method toTrailerRecord.TallyDataRecord(*lib.BaseSegment) errorandPackedTrailerRecord.TallyDataRecord(*lib.BaseSegment) errorto calculate trailer segment for each data record.