[chore] golang 1.23->1.24. k8s -> 1.34 #157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skamboj
reviewed
Oct 4, 2025
Contributor
skamboj
left a comment
skamboj
left a comment
There was a problem hiding this comment.
Any reason we can't go directly to 1.25?
Contributor
|
Thank you so much for this PR and your other one. I can get those released. However, we do need the commits to be properly signed - Please see this check: https://github.com/bloomberg/goldpinger/pull/157/checks?check_run_id=51520209665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request:
Did not create discovered while doing #155
Describe your changes
Take us to go 1.24 and k8s .34.1. Also brings up /net which I think had a cve.
Testing performed
Nothing yet.
Additional context
Add any other context about your contribution here.