Optionally use Readiness in GetAll Pods. #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 97f2344.
paulgmiller
commented
Sep 29, 2025
| } | ||
|
|
||
| // isReady is equivalent to k8s.io/kubectl/pkg/util/podutils.IsPodReady" but that brings us up a go version | ||
| // if we don't mind those dependencies could replace. |
Author
There was a problem hiding this comment.
going to latest dependencies brough it go 1.24 in go mod assume you'd want that as seperate change.
paulgmiller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #155
Describe your changes
Optional mode to use readiness in addition to running to filter pods
Testing performed
Ran this on our e2e during a couple of upgrades and qos maitainted higher.
Additional context
SImiliar to #134 from @j4ckstraw