Remove redundant health check route#5
Open
kleutzinger wants to merge 1 commit intoblockshiftnetwork:mainfrom
Open
Remove redundant health check route#5kleutzinger wants to merge 1 commit intoblockshiftnetwork:mainfrom
kleutzinger wants to merge 1 commit intoblockshiftnetwork:mainfrom
Conversation
The /api/health endpoint is already provided by Pocketbase, so there's no need to add a custom route. Simplified the CHECKS file to use the existing endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes deployment failures caused by duplicate route registration for /api/health. PocketBase has included a built-in /api/health endpoint since v0.10.0, making the custom hook redundant and causing route
conflicts.
Problem
When deploying to Dokku, the application would panic on startup with:
panic: pattern "GET /api/health" conflicts with pattern "GET /api/health"
This occurred because:
Changes
Before:
/api/health HTTP/1.1
Host: pocketbase
User-Agent: Dokku/1.0
After:
/api/health API is healthy
Result