Skip to content

Conversation

@tom2drum
Copy link
Collaborator

Description and Related Issue(s)

Resolves #3206

This PR fixes the issue where text selection in dark theme was not clearly visible. The changes add proper selection background colors for both light and dark themes to improve text selection visibility and maintain design consistency.

Proposed Changes

  • Added global.selection.bg semantic token with light (#E3CFE7) and dark (#754B7D) theme values in semanticTokens.ts
  • Applied the selection background color via ::selection pseudo-element in globalCss.ts
  • Ensures consistent and visible text selection across both themes

Breaking or Incompatible Changes

None.

Additional Information

This addresses the issue where text selection in dark theme was not clearly visible. The new colors provide better contrast while maintaining design consistency.

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added a feature or functionality that is not privacy-compliant (e.g., tracking, analytics, third-party services), I have disabled it for private mode.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@tom2drum tom2drum added bug Something isn't working design For issues and PRs related to UI and UX improvements labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working design For issues and PRs related to UI and UX improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Highlight color in dark theme

2 participants