[DEV-369] Fix behaviour on VotingPowerByAccountId endpoint #1584
+21
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PedroBinotto
requested review from
LeonardoVieira1630,
alextnetto,
brunod-e,
edulennert and
pikonha
as code owners
pikonha
reviewed
Jan 27, 2026
| } | ||
|
|
||
| return { | ||
| return result ? { |
Member
There was a problem hiding this comment.
shouldn't this return null and let the service handle the default value?
Member
There was a problem hiding this comment.
it could in fact be a thing added to the API response schema and handled this way
Member
There was a problem hiding this comment.
nvm, I've tried and it didn't look good
brunod-e
approved these changes
Jan 28, 2026
pikonha
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Changed return value when querying an address that has no values associated to it from:
{ "error": "Internal Server Error", "message": "Account not found" }to:
{ "accountId": "0xdadB0d80178819F2319190D340ce9A924f783711", "votingPower": "0", "votesCount": 0, "proposalsCount": 0, "delegationsCount": 0 }The same behaviour is currently applied to the
accountBalanceByAccountIdandvotingPowerVariationsByAccountIdqueries (meaning the previous, 500 status error); I would like @pikonha's advide for us to settle on a standard for this type of situation.