fix: change ds folder and cleanup unused components #1571
+204
−928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunod-e
requested review from
LeonardoVieira1630,
PedroBinotto,
alextnetto,
edulennert and
pikonha
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures the design system by moving it from shared/components/design-system/ to shared/design-system/ and removes several unused components to eliminate dead code.
Changes:
- Moved entire design-system folder from nested location to be a sibling of the components folder
- Removed unused components: DaoTemplate, TheTable, SkeletonDaoInfoCards, TelegramBotMessage, Sparkline, SwitchCardDaoInfoItem, BaseCardDaoInfo, Badge, InlineAlert (old version), BannerAlert (old version)
- Updated all import paths across the codebase from
@/shared/components/design-system/*to@/shared/design-system/* - Updated documentation in .cursor/rules/design.mdc to reflect new import paths
Reviewed changes
Copilot reviewed 131 out of 167 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/dashboard/templates/index.ts | Removed export of deleted DaoTemplate |
| apps/dashboard/templates/DaoTemplate.tsx | Deleted unused DAO template component |
| apps/dashboard/shared/design-system/* | Moved design-system components from nested location (83 files added) |
| apps/dashboard/shared/components/design-system/* | Removed old design-system location (27 files deleted) |
| apps/dashboard/shared/components/index.ts | Updated exports to reference new design-system location |
| apps/dashboard/shared/components/**/!(index).tsx | Updated import paths throughout codebase (100+ files) |
| apps/dashboard/features/**/!(index).tsx | Updated import paths in feature files (50+ files) |
| apps/dashboard/app/**/page.tsx | Updated import paths in page components (15+ files) |
| .cursor/rules/design.mdc | Updated documentation with new import paths |
| Deleted components | Removed 9 unused components including Badge, BaseCardDaoInfo, TheTable, etc. |
Comments suppressed due to low confidence (1)
apps/dashboard/shared/design-system/links/underlined-link/UnderlinedLink.tsx:20
- The className string contains both
text-smandtext-[13px]which specify conflicting text sizes. In Tailwind CSS, when multiple utilities of the same property are present, the last one in the source order wins. This meanstext-[13px]will overridetext-sm. Remove the redundanttext-smclass to avoid confusion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved design-system folder to outside components folder and cleanup unused components to avoid dead code