Refactor/historical voting power #1568
Open
+535
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
LeonardoVieira1630
requested review from
PedroBinotto,
alextnetto,
brunod-e,
edulennert and
pikonha
as code owners
brunod-e
approved these changes
Jan 23, 2026
PedroBinotto
requested changes
Jan 26, 2026
pikonha
reviewed
Jan 26, 2026
pikonha
reviewed
Jan 26, 2026
pikonha
requested changes
Jan 26, 2026
Member
pikonha
left a comment
pikonha
left a comment
There was a problem hiding this comment.
some coments need to fixed and also the conflicts
pikonha
reviewed
Jan 28, 2026
| description: "Returns a list of voting power changes.", | ||
| tags: ["proposals"], | ||
| request: { | ||
| query: HistoricalVotingPowerGlobalQuerySchema, |
Member
There was a problem hiding this comment.
what's the difference between this one and the historicalVotingPowerByAccountId if both receive just an address as an argument?
Member
Author
There was a problem hiding this comment.
On this one the address is not necessary. I let address as an possible argument, but it is optional. The other one (/voting-power/{address}/historical) needs the address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Notification System needs a route the returns votingPower historical variations for all the users of a DAO. On this pr we: