Make launcher Activity adapted for large screen #154
Conversation
Test it on Pixel 9 Fold Emulator, and it occupied full screen. Signed-off-by: utzcoz <utzcoz@outlook.com>
|
Hi @michaelneale, please take a look. Thanks. |
| android:exported="true" | ||
| android:label="Goose Mobile Launcher" | ||
| android:launchMode="singleTask" | ||
| android:screenOrientation="portrait" |
There was a problem hiding this comment.
I might be totally in the wrong, be setting android:screenOrientation to its default value won't cause any issue?
Why did we force it to "portrait" in the first place?
There was a problem hiding this comment.
screenOrientation is ignored (or is equivalent to unspecified) when apps run in multi‑window mode. So, if you restrict your app to one orientation, the app might not work properly in multi‑window mode.
Normally, it will be considered by system as it is not in multi-window mode.
See https://developer.android.com/guide/topics/manifest/activity-element#screen,
If the app is targeted with SDK 36, the value will be ignored, but the goose-mobile uses targetSdk 34 now.
If the goose-mobile requires portrait for old devices with some reasons, it can be kept, otherwise I recommend removing it.
|
nice - sorry not sure how I missed this. |
3 participants
Test it on Pixel 9 Fold Emulator, and it occupied full screen.
Before:
After:
