[VIDEO-3086] Configure gst-plugins-rs source, ref#18
Conversation
Signed-off-by: Thomas Goodwin <thomas.goodwin@laerdal.com>
a504b93 to
3acc266
Compare
This patch release includes our aws3sink w/ cache and intersink changes
|
I'm stumped. Earlier I let it run with a different existing tag and it was fine. Now it's not with the new tag. Their readme says "branch"...which won't be great; the variable is called commits after all. |
The spec for git reset --hard is <commit>, which does accept a remote name but goes to the head of the branch (`remote/branch` format). If we need to target a tag, our tag must be unique.
|
Look'n good. It made it past the |
jawilson
left a comment
There was a problem hiding this comment.
We'll need to also update the config-hash calculation. I'd suggest something simple like:
config_hash=$(echo "${CERBERO_ARGS}${{ inputs.config }}${GST_PLUGINS_RS_SOURCE}${GST_PLUGINS_RS_REF}" | sha256sum | cut -d' ' -f1)
These were suggestions from PR comments. Co-authored-by: Jeff Wilson <jeffery.wilson@laerdal.com>
jawilson
left a comment
There was a problem hiding this comment.
LGTM assuming the build passes.
|
@jawilson Well, it's through the wickets but I can't merge to the branch because it's protected. I assume you have permission? |
Got a little carried away with the branch protection rulesets. I couldn't merge either. Updated and good to merge now. |
Updated the github action to add
recipes_remotesandrecipes_commitsinto the configuration file, pointinggst-plugins-rsat our repository. The target including the following two changes is0.12.9-lldc.1, here.