Skip to content

Upgrade RoaringBitmap/roaring/v2, vellum, mmap-go etc.#360

Merged
abhinavdangeti merged 13 commits intomasterfrom
upgrade
Jan 26, 2026
Merged

Upgrade RoaringBitmap/roaring/v2, vellum, mmap-go etc.#360
abhinavdangeti merged 13 commits intomasterfrom
upgrade

Conversation

@CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Jan 9, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades multiple dependencies in the zapx Go module, including major version bumps for several core libraries and the Go toolchain version itself.

Key Changes:

  • Upgraded Go toolchain from 1.23 to 1.24.0
  • Updated RoaringBitmap from v2.4.5 to v2.14.4 (significant version jump)
  • Updated multiple other dependencies including snappy, cobra, and various indirect dependencies

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updated Go version and direct/indirect dependency versions
go.sum Updated checksums for all upgraded dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold off on this change - unstable-v17 is currently only for the backport. This commit will go directly to master later.

@CascadingRadium
Copy link
Member Author

hey @abhinavdangeti, i think we can upgrade the deps to latest for the first tagged zapx release for v17, i.e. v17.0.0 and then use that tag for both the back-port and for master. I think this can be done after merging unstable-v17 into master and creating the tag from the master branch itself.

@abhinavdangeti
Copy link
Member

No, we're not gonna upgrade these dependencies for the backport - let's do this after after we're set there.

Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase this over master. We'll get to it later though.

@CascadingRadium CascadingRadium changed the base branch from unstable-v17 to master January 15, 2026 18:35
@abhinavdangeti abhinavdangeti changed the title [v17] Upgrade deps Upgrade RoaringBitmap/roaring/v2, vellum etc. Jan 22, 2026
abhinavdangeti
abhinavdangeti previously approved these changes Jan 22, 2026
abhinavdangeti
abhinavdangeti previously approved these changes Jan 22, 2026
@abhinavdangeti abhinavdangeti changed the title Upgrade RoaringBitmap/roaring/v2, vellum etc. Upgrade RoaringBitmap/roaring/v2, vellum etc. Jan 22, 2026
@abhinavdangeti abhinavdangeti changed the title Upgrade RoaringBitmap/roaring/v2, vellum etc. Upgrade RoaringBitmap/roaring/v2, vellum, mmap-go etc. Jan 22, 2026
@CascadingRadium
Copy link
Member Author

Hi @abhinavdangeti, I don't think disabling the unit tests on windows is a good idea. I have fixed the windows unit test issue and enabled windows CI here -> #369.

@abhinavdangeti
Copy link
Member

Good call, add your commit to this PR then.

abhinavdangeti
abhinavdangeti previously approved these changes Jan 26, 2026
Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdangeti abhinavdangeti merged commit 55fadce into master Jan 26, 2026
9 of 18 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Geo-Spatial Search v2 Jan 26, 2026
@abhinavdangeti abhinavdangeti deleted the upgrade branch January 26, 2026 20:34
@abhinavdangeti
Copy link
Member

v17.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

fix unit tests on windows

2 participants