MB-69881: Updated interfaces for more performant vector search#82
MB-69881: Updated interfaces for more performant vector search#82abhinavdangeti merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors vector search to use an iterator-based abstraction for accessing eligible documents, replacing the previous slice-based approach. The changes introduce two new interfaces (EligibleDocumentIterator and EligibleDocumentList) and modify the EligibleDocumentSelector interface to support streaming access patterns, eliminating the need for intermediate materialization of eligible document IDs.
Key Changes:
- Introduced
EligibleDocumentIteratorinterface for streaming document ID iteration - Introduced
EligibleDocumentListinterface as a container providing both iterator access and count information - Modified
EligibleDocumentSelector.SegmentEligibleDocs()to returnEligibleDocumentListinstead of[]uint64
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EligibleDocumentList / EligibleDocumentIterator), enabling storage-layer streaming/visitor-style consumption of eligible docIDs, eliminating intermediate materialization, and decoupling retrieval from underlying eligible-document storage representations.