Skip to content

MB-69881: Updated interfaces for more performant vector search#82

Merged
abhinavdangeti merged 2 commits intomasterfrom
perf
Jan 9, 2026
Merged

MB-69881: Updated interfaces for more performant vector search#82
abhinavdangeti merged 2 commits intomasterfrom
perf

Conversation

@CascadingRadium
Copy link
Member

  • Replace slice-based eligible document access with an iterator-based abstraction (EligibleDocumentList / EligibleDocumentIterator), enabling storage-layer streaming/visitor-style consumption of eligible docIDs, eliminating intermediate materialization, and decoupling retrieval from underlying eligible-document storage representations.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors vector search to use an iterator-based abstraction for accessing eligible documents, replacing the previous slice-based approach. The changes introduce two new interfaces (EligibleDocumentIterator and EligibleDocumentList) and modify the EligibleDocumentSelector interface to support streaming access patterns, eliminating the need for intermediate materialization of eligible document IDs.

Key Changes:

  • Introduced EligibleDocumentIterator interface for streaming document ID iteration
  • Introduced EligibleDocumentList interface as a container providing both iterator access and count information
  • Modified EligibleDocumentSelector.SegmentEligibleDocs() to return EligibleDocumentList instead of []uint64

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abhinavdangeti abhinavdangeti changed the title MB-69881: Re-architect vector search MB-69881: Updated interfaces for more performant vector search Jan 8, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abhinavdangeti abhinavdangeti merged commit f19a6d6 into master Jan 9, 2026
15 checks passed
@abhinavdangeti abhinavdangeti deleted the perf branch January 9, 2026 15:46
@CascadingRadium CascadingRadium restored the perf branch January 10, 2026 07:32
@CascadingRadium CascadingRadium deleted the perf branch January 10, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants