Merged
Conversation
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to modernize the GitHub Actions workflow by upgrading from actions/setup-go@v1 to v5 and updating the Go version requirements. However, the changes introduce critical issues related to Go version formats and unreleased Go versions.
- Upgrades GitHub Actions setup-go action from v1 to v5
- Updates Go version in go.mod from 1.21 to 1.24.0
- Modifies the test matrix to use Go versions 1.23.x, 1.24.x, and 1.25.x
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates the Go version directive, but uses incorrect format (1.24.0 instead of 1.24) and references an unreleased version |
| .github/workflows/tests.yml | Upgrades actions/setup-go to v5 and updates test matrix with Go versions, but includes unreleased versions (1.24.x, 1.25.x) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhinavdangeti
previously approved these changes
Dec 30, 2025
go.mod
Outdated
| module github.com/blevesearch/bleve_index_api | ||
|
|
||
| go 1.21 | ||
| go 1.24.0 |
abhinavdangeti
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/setup-go@v1toactions/setup-go@v5go 1.24.0