Align go version and bleve dependency to v2.4.4#18
Align go version and bleve dependency to v2.4.4#18abhinavdangeti merged 12 commits intoblevesearch:masterfrom
Conversation
christiangda
commented
Feb 27, 2025
- fix: remove unused type
- fix: verify error
- fix: use http.StatusXX const instead of int value
- feat: improve log output to show link directly
- fix: deprecated notice about ioutil package
- fix: deprecated notice about ioutil package and warning about build command
- fix: highlight code as bash
- feat: align the go version and dependencies with the version v2.4.4 of bleve
|
hi @mschoch and @abhinavdangeti, is there a chance to review this PR? or is there no way to contribute to this repository? |
|
@christiangda thanks for the contribution. Would you update https://github.com/blevesearch/beer-search/blob/master/.github/workflows/tests.yml#L11 as well to run over 1.21, 1.22, 1.23. |
DONE ✅ |
@abhinavdangeti looks like the code is not compatible anymore with go v1.15, let me know if you want me to change something in the workflow |
.github/workflows/tests.yml
Outdated
| strategy: | ||
| matrix: | ||
| go-version: [1.14.x, 1.15.x] | ||
| go-version: [1.14.x, 1.15.x, 1.21.x, 1.22.x, 1.23.x] |
There was a problem hiding this comment.
Drop support for 1.14.x and 1.15.x.
There was a problem hiding this comment.
I can't push patches to this pull request - so you'll need to raise a patch here to remove the older versions.
There was a problem hiding this comment.
hye @abhinavdangeti, let me try to fix the tests that are falling in the workflow; sorry, I didn't check these.
