Skip to content

Align go version and bleve dependency to v2.4.4#18

Merged
abhinavdangeti merged 12 commits intoblevesearch:masterfrom
christiangda:fix-align-go-version-bleve
Mar 5, 2025
Merged

Align go version and bleve dependency to v2.4.4#18
abhinavdangeti merged 12 commits intoblevesearch:masterfrom
christiangda:fix-align-go-version-bleve

Conversation

@christiangda
Copy link
Contributor

  • fix: remove unused type
  • fix: verify error
  • fix: use http.StatusXX const instead of int value
  • feat: improve log output to show link directly
  • fix: deprecated notice about ioutil package
  • fix: deprecated notice about ioutil package and warning about build command
  • fix: highlight code as bash
  • feat: align the go version and dependencies with the version v2.4.4 of bleve

@christiangda
Copy link
Contributor Author

hi @mschoch and @abhinavdangeti, is there a chance to review this PR? or is there no way to contribute to this repository?

@abhinavdangeti
Copy link
Member

@christiangda thanks for the contribution. Would you update https://github.com/blevesearch/beer-search/blob/master/.github/workflows/tests.yml#L11 as well to run over 1.21, 1.22, 1.23.

@christiangda
Copy link
Contributor Author

@christiangda thanks for the contribution. Would you update https://github.com/blevesearch/beer-search/blob/master/.github/workflows/tests.yml#L11 as well to run over 1.21, 1.22, 1.23.

DONE ✅

@christiangda
Copy link
Contributor Author

@christiangda thanks for the contribution. Would you update https://github.com/blevesearch/beer-search/blob/master/.github/workflows/tests.yml#L11 as well to run over 1.21, 1.22, 1.23.

@abhinavdangeti looks like the code is not compatible anymore with go v1.15, let me know if you want me to change something in the workflow
Screenshot 2025-03-04 at 16 24 18

strategy:
matrix:
go-version: [1.14.x, 1.15.x]
go-version: [1.14.x, 1.15.x, 1.21.x, 1.22.x, 1.23.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop support for 1.14.x and 1.15.x.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't push patches to this pull request - so you'll need to raise a patch here to remove the older versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdangeti DONE ✅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hye @abhinavdangeti, let me try to fix the tests that are falling in the workflow; sorry, I didn't check these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@abhinavdangeti abhinavdangeti changed the title fix: aling go version and bleve dependecy to v2.4.4 Align go version and bleve dependency to v2.4.4 Mar 5, 2025
@abhinavdangeti abhinavdangeti merged commit dca7c15 into blevesearch:master Mar 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants