Skip to content

use lowercase a-f in create_str and create_hex #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waltman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use lowercase a-f in create_str and create_hex #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions UUID.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,17 +225,17 @@ static SV* make_ret(const perl_uuid_t u, int type) {
len = sizeof(perl_uuid_t);
break;
case F_STR:
sprintf(buf, "%8.8X-%4.4X-%4.4X-%2.2X%2.2X-", (unsigned int)u.time_low, u.time_mid,
sprintf(buf, "%8.8x-%4.4x-%4.4x-%2.2x%2.2x-", (unsigned int)u.time_low, u.time_mid,
u.time_hi_and_version, u.clock_seq_hi_and_reserved, u.clock_seq_low);
for(i = 0; i < 6; i++ )
sprintf(buf+strlen(buf), "%2.2X", u.node[i]);
sprintf(buf+strlen(buf), "%2.2x", u.node[i]);
len = strlen(buf);
break;
case F_HEX:
sprintf(buf, "0x%8.8X%4.4X%4.4X%2.2X%2.2X", (unsigned int)u.time_low, u.time_mid,
sprintf(buf, "0x%8.8x%4.4x%4.4x%2.2x%2.2x", (unsigned int)u.time_low, u.time_mid,
u.time_hi_and_version, u.clock_seq_hi_and_reserved, u.clock_seq_low);
for(i = 0; i < 6; i++ )
sprintf(buf+strlen(buf), "%2.2X", u.node[i]);
sprintf(buf+strlen(buf), "%2.2x", u.node[i]);
len = strlen(buf);
break;
case F_B64:
Expand Down
4 changes: 3 additions & 1 deletion t/basic.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use strict;
use warnings;

use Test::More tests => 28;
use Test::More tests => 30;

BEGIN { use_ok('Data::UUID'); }

Expand Down Expand Up @@ -42,3 +42,5 @@ for my $uuid (keys %uuids) {
);
}

ok($ug->create_str =~ /^[0-9a-f\-]*$/, "create_str only contains lowercase hex digits or dashes");
ok($ug->create_hex =~ /^0x[0-9a-f]*$/, "create_hex only contains lowercase hex digits");